Replace file feature for FAL file list - doesn't work if storage id is not 1
There is an error in the REPLACE file feature in FAL.
System storage UID is hard-coded to 1.
typo3/sysext/core/Classes/Utility/File/ ExtendedFileUtility.php line 1076:
$folder = $resourceFactory->getFolderObjectFromCombinedIdentifier('1:'.$fileObject->getParentFolder()->getIdentifier());
In big percentage, we are using auto created 'fileadmin' but here is obvious that this code will not work for any other Storage except fileadmin with UID 1.
Here I would read the storage from file object.
If you have situation like on picture attached this will not work for you.
Please check provided patch.
#3 Updated by Dragan Tomic about 3 years ago
Frans Saris wrote:
What version are you using? Can find this in the our current 6.2 branch. Also the linked change doesn't have this code.
Ah sorry, now I saw that this is accepted first in version 7.x :(
We have it in our internal Typo3 source which we sync with official but I see it is accepted as feature in next major release.
Since we have connection to the original Ticket with implementation https://forge.typo3.org/issues/56133 maybe someone can still use it :)
#4 Updated by Frans Saris about 3 years ago
- Status changed from Needs Feedback to Rejected
Ok, tnx for the feedback. Closed this issue.
But if I understand you correctly this is in one of the older versions of TYPO3? Or only in your custom version?
$folder = $resourceFactory->getFolderObjectFromCombinedIdentifier('1:'.$fileObject->getParentFolder()->getIdentifier()); is a very strange construction that shouldn't be used any where in the core.