Bug #79131

Wrong type in PageRepository::getDomainStartPage for column fe_group

Added by Manuel Selbach over 2 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2017-01-02
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Use of incorrect type for column fe_group in the method PageRepository::getDomainStartPage.
If a DBMS with strict usage of types is used (e.g. Postgres), the method will throw an exception, as the 0 is of type integer and not of type string as the column is defined in the database and thus a comparison will fail.

Associated revisions

Revision a526ce95 (diff)
Added by Manuel Selbach over 2 years ago

[BUGFIX] Use correct type in PageRepository::getDomainStartPage for column fe_group

Strict DBMS will throw an exception for a query where to compare an integer against a column with string values.
There will no "magic" type casting processed, thus we have to use a string instead of an integer.

Change-Id: I740d1797c92f203e83ddfec2ab00df42cc5c53aa
Resolves: #79131
Releases: master
Reviewed-on: https://review.typo3.org/51096
Tested-by: TYPO3com <>
Reviewed-by: Morton Jonuschat <>
Tested-by: Morton Jonuschat <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51096

#2 Updated by Manuel Selbach over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF