Bug #79447

Unify usage of fe_group in tables of TYPO3 core

Added by Manuel Selbach almost 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2017-01-24
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The column "fe_group" is defined as varchar everywhere in the core except in table "sys_collection".
This will cause some problems with some DBMS (e.g. PostgreSQL) as the FrontendGroupRestriction::class will generate a query which will e.g. check against empty string.
Thus the column "fe_group" should be unified to varchar.

Example:
The following tests fail with the column "fe_group" defined as integer:
- RecordCollectionRepositoryTest::doesFindByUidReturnAnObjectInFrontendMode
- RecordCollectionRepositoryTest::doesFindByUidRespectEnableFieldsInFrontendMode

Associated revisions

Revision 27fcf170 (diff)
Added by Manuel Selbach almost 3 years ago

[BUGFIX] Convert fe_group in sys_collection to VARCHAR

The core methods dealing with frontend group restrictions expect this
field to be of a character based datatype. Comparing an integer based
field with string triggers query errors on PostgreSQL which
does not perform implict type conversions.

Resolves: #79447
Releases: master
Change-Id: Idc937e71d578e5f4a81595124c3aef53d32b2ed7
Reviewed-on: https://review.typo3.org/51392
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51392

#2 Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51392

#3 Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51392

#4 Updated by Manuel Selbach almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF