Project

General

Profile

Actions

Bug #79687

closed

Missing else statement in Css Styles Content causes images not to be outputted

Added by Christer V about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
Start date:
2017-02-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In the new Css Styles Content there seems to be missing an else.

In TYPO3\CMS\CssStyledContent\Controller\CssStyledContentController::render_textpic

if $accessibilityMode is set to false and $separateRows is also false.

$allRows is never added to $thisImages.

Changing the code to:

if ($separateRows) {
    $thisImages .= $allRows;
}
else {
    $thisImages .= $this->cObj->stdWrap($allRows, $conf['noRowsStdWrap.']);
}

like it was before, seems to fix it.
Actions #1

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51583

Actions #2

Updated by Gerrit Code Review about 7 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51585

Actions #3

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51585

Actions #4

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51585

Actions #5

Updated by Christer V about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF