Bug #79687

Missing else statement in Css Styles Content causes images not to be outputted

Added by Christer V over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
Start date:
2017-02-08
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In the new Css Styles Content there seems to be missing an else.

In TYPO3\CMS\CssStyledContent\Controller\CssStyledContentController::render_textpic

if $accessibilityMode is set to false and $separateRows is also false.

$allRows is never added to $thisImages.

Changing the code to:

if ($separateRows) {
    $thisImages .= $allRows;
}
else {
    $thisImages .= $this->cObj->stdWrap($allRows, $conf['noRowsStdWrap.']);
}

like it was before, seems to fix it.

Associated revisions

Revision 1b8ae698 (diff)
Added by Christer V over 2 years ago

[BUGFIX] EXT:css_styled_content: always render all images

In CssStyledContentController::render_textpic if $accessibilityMode
evaluates to false and $separateRows is also false, $allRows is never
added to $thisImages. This causes images to not be outputted
to the frontend.

Resolves: #79687
Releases: master
Change-Id: I918741aaa8724837ef87567d481072ceedf275fa
Reviewed-on: https://review.typo3.org/51585
Reviewed-by: Daniel Goerz <>
Tested-by: TYPO3com <>
Reviewed-by: Benjamin Kott <>
Tested-by: Benjamin Kott <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51583

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51585

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51585

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51585

#5 Updated by Christer V over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF