Bug #79759

Failing unit tests on Windows system in TYPO3\CMS\Install\Tests\Unit\UpgradeAnalysis\DocumentationFileTest

Added by Nicole Cordes over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
-
Target version:
Start date:
2017-02-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

Due to wrong path handling in \TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile several unit tests fail on Windows systems because of the usage of DIRECTORY_SEPARATOR constant.

TYPO3\CMS\Install\Tests\Unit\UpgradeAnalysis\DocumentationFileTest::findDocumentationFilesReturnsArrayOfFiles
InvalidArgumentException: the given file does not belong to the changelog dir. Aborting

D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\install\Classes\UpgradeAnalysis\DocumentationFile.php:95
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\install\Classes\UpgradeAnalysis\DocumentationFile.php:236
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\install\Classes\UpgradeAnalysis\DocumentationFile.php:79
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\install\tests\Unit\UpgradeAnalysis\DocumentationFileTest.php:145

TYPO3\CMS\Install\Tests\Unit\UpgradeAnalysis\DocumentationFileTest::extractingTagsProvidesTagsAsDesired
InvalidArgumentException: the given file does not belong to the changelog dir. Aborting

D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\install\Classes\UpgradeAnalysis\DocumentationFile.php:95
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\install\Classes\UpgradeAnalysis\DocumentationFile.php:236
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\install\Classes\UpgradeAnalysis\DocumentationFile.php:79
D:\Version Control\Git\TYPO3\TYPO3.CMS\master\typo3\sysext\install\tests\Unit\UpgradeAnalysis\DocumentationFileTest.php:158

TYPO3\CMS\Install\Tests\Unit\UpgradeAnalysis\DocumentationFileTest::filesAreFilteredByUsersChoice
InvalidArgumentException: the given file does not belong to the changelog dir. Aborting
#1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51637

#2

Updated by Nicole Cordes over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#3

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF