Project

General

Profile

Actions
Copy link

Task #80207

closed

Cleanup retrieval of hash-value and processing in ReferenceIndex

Added by Andreas Allacher over 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Target version:
next-patchlevel
Start date:
2017-03-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

In \TYPO3\CMS\Core\Database\ReferenceIndex the updateRefIndexTable method sets
$currentRelations[$relation['hash']] = $currentRelations; which not really makes sense.

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/core/Classes/Database/ReferenceIndex.php#l224

Since the relation is not used - it would be sufficient to:
  1. Fetch the hash value
  2. Set $currentRelationHashes[$relation['hash']] to true since we only use it to process the records aftwards
Actions
Copy link
 #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51989

Actions
Copy link
 #2

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51989

Actions
Copy link
 #3

Updated by Thomas Hohn over 7 years ago

  • Tracker changed from Bug to Task
  • Description updated (diff)
Actions
Copy link
 #4

Updated by Thomas Hohn over 7 years ago

  • Subject changed from Reference Index currentRelations retrievl wrong in updateRefIndexTable to Cleanup retrieval of hash-value and processing in ReferenceIndex
Actions
Copy link
 #5

Updated by Thomas Hohn over 7 years ago

  • Description updated (diff)
Actions
Copy link
 #6

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51989

Actions
Copy link
 #7

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51989

Actions
Copy link
 #8

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51989

Actions
Copy link
 #9

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51989

Actions
Copy link
 #10

Updated by Benni Mack over 7 years ago

  • Target version changed from 8 LTS to next-patchlevel
Actions
Copy link
 #11

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52722

Actions
Copy link
 #12

Updated by Anonymous over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #13

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF