Project

General

Profile

Actions

Bug #80495

closed

Refactored click menu should handle priorities above the priority of RecordProvider properly

Added by Thomas Hohn about 7 years ago. Updated about 7 years ago.

Status:
Rejected
Priority:
Must have
Assignee:
Category:
Backend API
Target version:
-
Start date:
2017-03-27
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

In TYPO3 7.6 it was possible to add menu items to the the top of the click menu
for instance in the List-Module.

We have a use-case with at custom table - where it should be possible to show a preview of the Item as well as
normal Record operations like edit etc. In current version of TYPO3 8 this is not possible AFAIK.
The location of menu items is handled via the getPriority method in the ProviderInterface in TYPO3 8.

Unfortunately the current implementation of the method addItems in RecordProvider class
prohibits entries above the priority in RecordProvider (60) which is what we want - due to the following code:

public function addItems(array $items): array
    {
        if (!empty($items)) {
            return $items;
        }
        $this->initialize();
        return $this->prepareItems($this->itemsConfiguration);
    }

Which means defining items with at priority above 60 will result in only these items being displayed
and NOT additionally items with a priority below 60.


Files

Priority-below-60.png (36.1 KB) Priority-below-60.png Priority below 60 Thomas Hohn, 2017-03-27 18:47
Priority-above-60.png (14.9 KB) Priority-above-60.png Priority above 60 Thomas Hohn, 2017-03-27 18:47
Desired-behaviour.png (36.5 KB) Desired-behaviour.png Desired behaviour Thomas Hohn, 2017-03-27 18:47
Actions #2

Updated by Gerrit Code Review about 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52191

Actions #3

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52191

Actions #4

Updated by Thomas Hohn about 7 years ago

  • Description updated (diff)
Actions #5

Updated by Thomas Hohn about 7 years ago

  • Subject changed from Refactored click menu should respect priority above the priority of RecordProvider to Refactored click menu should handle priorities above the priority of RecordProvider properly
Actions #6

Updated by Thomas Hohn about 7 years ago

  • Description updated (diff)
Actions #7

Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52191

Actions #8

Updated by Benni Mack about 7 years ago

  • Target version deleted (8 LTS)
Actions #9

Updated by Thomas Hohn about 7 years ago

  • Status changed from Under Review to Rejected

Can be solved in other ways - the documentation should showever be updated - Will create a PR for that.

Actions

Also available in: Atom PDF