Project

General

Profile

Actions
Copy link

Bug #80755

closed

Remove depreciated code from ExtensionManagementUtility for T3 7 LTS

Added by Kurt Ludikovsky about 7 years ago. Updated about 7 years ago.

Status:
Rejected
Priority:
Must have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2017-04-07
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The following entry was found in the deprections log

07-04-17 19:50: TYPO3\CMS\Core\Utility\ExtensionManagementUtility::loadNewTcaColumnsConfigFiles() - since TYPO3 CMS 7, will be removed in TYPO3 CMS 8. Table definition should be moved to <your_extension>/Configuration/TCA/<table_name> - call_user_func#34 // {closure}# // TYPO3\CMS\Frontend\Http\Application->run#33 // TYPO3\CMS\Core\Core\Bootstrap->handleRequest#78 // TYPO3\CMS\Frontend\Http\RequestHandler->handleRequest#302 // TYPO3\CMS\Core\Core\Bootstrap->loadExtensionTables#134 // TYPO3\CMS\Core\Utility\ExtensionManagementUtility::loadExtTables#974 // TYPO3\CMS\Core\Cache\Frontend\PhpFrontend->requireOnce#1876 // TYPO3\CMS\Core\Cache\Backend\SimpleFileBackend->requireOnce#77 // require_once(typo3temp/Cache/Code/cache_core/ext_tables_d9b8e39b9bd0b2cee68920f678d4001ef82f0292.php),typo3_src-7.6.16/typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php#382 // TYPO3\CMS\Core\Utility\ExtensionManagementUtility::loadNewTcaColumnsConfigFiles#3174 // TYPO3\CMS\Core\Utility\GeneralUtility::logDeprecatedFunction#1985 (typo3_src-7.6.16/typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php#1977)

Shall be cleaned up as near transitioning to t3 8 is least likely due to lack of available extensions.

Actions
Copy link
 #1

Updated by Morton Jonuschat about 7 years ago

  • Status changed from New to Needs Feedback

This is a hint that warns you that you have code in your current installation which is using methods they shouldn't be using anymore, being incompatible with a future update to TYPO3 v8.
Why should this hint be dropped from TYPO3 v7?

Actions
Copy link
 #2

Updated by Wouter Wolters about 7 years ago

  • Status changed from Needs Feedback to Rejected

As morton explains this is a hint that the code will be removed in TYPO3 v8 (which is the case offcourse).
The deprecation log is there for this reason to warn you about code that will be dropped in a new major release.

Actions
Copy link
 #3

Updated by Kurt Ludikovsky about 7 years ago

As this - if I understand the message correctly - originates from within the core.

call_user_func#34 //
         {closure}# //
         TYPO3\CMS\Frontend\Http\Application->run#33 //
         TYPO3\CMS\Core\Core\Bootstrap->handleRequest#78 //
         TYPO3\CMS\Frontend\Http\RequestHandler->handleRequest#302 //
         TYPO3\CMS\Core\Core\Bootstrap->loadExtensionTables#134 //
         TYPO3\CMS\Core\Utility\ExtensionManagementUtility::loadExtTables#974 //
         TYPO3\CMS\Core\Cache\Frontend\PhpFrontend->requireOnce#1876 //
         TYPO3\CMS\Core\Cache\Backend\SimpleFileBackend->requireOnce#77 //
         require_once(typo3temp/Cache/Code/cache_core/ext_tables_d9b8e39b9bd0b2cee68920f678d4001ef82f0292.php),typo3_src-7.6.16/typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php#382 //
         TYPO3\CMS\Core\Utility\ExtensionManagementUtility::loadNewTcaColumnsConfigFiles#3174 //
         TYPO3\CMS\Core\Utility\GeneralUtility::logDeprecatedFunction#1985 (typo3_src-7.6.16/typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php#1977)

If I check the sysext it is called from


core/Classes/Utility/ExtensionManagementUtility.php:1906: static::loadNewTcaColumnsConfigFiles();
core/Classes/Utility/ExtensionManagementUtility.php:1946: $phpCodeToCache[] = self::class . '::loadNewTcaColumnsConfigFiles();';
core/Classes/Utility/ExtensionManagementUtility.php:1977: public static function loadNewTcaColumnsConfigFiles()
core/Classes/Category/CategoryRegistry.php:105: ExtensionManagementUtility::loadNewTcaColumnsConfigFiles();
core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php:1719: // Tests concerning loadNewTcaColumnsConfigFiles
core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php:1726: public function loadNewTcaColumnsConfigFilesIncludesDefinedDynamicConfigFileIfNoColumnsExist()
core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php:1735: ExtensionManagementUtility::loadNewTcaColumnsConfigFiles();
core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php:1741: public function loadNewTcaColumnsConfigFilesDoesNotIncludeFileIfColumnsExist()
core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php:1753: ExtensionManagementUtility::loadNewTcaColumnsConfigFiles();
install/Classes/Controller/Action/Ajax/ExtensionCompatibilityTester.php:172: ExtensionManagementUtility::loadNewTcaColumnsConfigFiles();

but not from any of the installed extensions in typo3conf.

So the question is why is a function that is depreciated still used in the core.

Appart from possible bad style, it adds additional burden to the execution, as the exception will be thrown and executed each and every time the function is called.
And as it seems that this function is called with each FE-access thru

TYPO3\CMS\Frontend\Http\Application->run#33 //

this is a lot of burden to operational systems I would think.

But I might be misinterpreting something.

Actions
Copy link
 #4

Updated by Kurt Ludikovsky about 7 years ago

My last remark overlapped with Wouiters response.

Actions
Copy link

Also available in: Atom PDF