Task #80788

Introduce cache for readLLfile() in \TYPO3\CMS\Lang\LanguageService

Added by Faton Haliti over 2 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2017-04-10
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The call is expensive - since it calls mergeRecursiveWithOverrule()
Copying a single page with 2000 FE users will fire the method 2000 times
degrading performance.

By introducing a cache one can achieve a better performance.

Associated revisions

Revision 77e61969 (diff)
Added by Faton Haliti over 2 years ago

[TASK] Introduce cache for readLLfile()

Cache the result of readLLfile() gives a better performance
for cases where readLLfile() is called often.

Resolves: #80788
Releases: master, 8.7
Change-Id: I59913c7c5124ebe54c567a0a7c126a32fdd60284
Reviewed-on: https://review.typo3.org/52406
Reviewed-by: Joerg Boesche <>
Tested-by: TYPO3com <>
Reviewed-by: Kasper Ligaard <>
Reviewed-by: Faton Haliti <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 71629357 (diff)
Added by Faton Haliti over 2 years ago

[TASK] Introduce cache for readLLfile()

Cache the result of readLLfile() gives a better performance
for cases where readLLfile() is called often.

Resolves: #80788
Releases: master, 8.7
Change-Id: I59913c7c5124ebe54c567a0a7c126a32fdd60284
Reviewed-on: https://review.typo3.org/52798
Tested-by: TYPO3com <>
Reviewed-by: Kasper Ligaard <>
Reviewed-by: Faton Haliti <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52406

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52406

#3 Updated by Thomas Hohn over 2 years ago

  • Subject changed from Introduce runtime cache for readLLfile() in \TYPO3\CMS\Lang\LanguageService to Introduce cache for readLLfile() in \TYPO3\CMS\Lang\LanguageService
  • Description updated (diff)

#4 Updated by Thomas Hohn over 2 years ago

  • Tracker changed from Bug to Task

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52406

#6 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52406

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52406

#8 Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52406

#9 Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52406

#10 Updated by Benni Mack over 2 years ago

  • Target version changed from 8 LTS to next-patchlevel

#11 Updated by Gerrit Code Review over 2 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52406

#12 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52798

#13 Updated by Gerrit Code Review over 2 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52406

#14 Updated by Faton Haliti over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF