Bug #80934

Use of getAttributeNode() is deprecated. Use getAttribute() instead.

Added by Pouyan A about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2017-04-21
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.6
Tags:
Firefox
Complexity:
Is Regression:
Sprint Focus:

Description

On Firefox 54 onward (auch 55), getAttributeNode() is deprecated:

This leads to errors on the RTE internal link selector, the select does not work at all.

TypeError: node.getAttributeNode(...) is null[Learn More] TYPO3Link.js:320:29
    setLinkAttributes https://.../typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/TYPO3Link.js:320:29
    setLinkAttributes https://.../typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/TYPO3Link.js:353:7
    createLink https://.../typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/TYPO3Link.js:253:6
    LinkBrowser.finalizeFunction https://v/typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/RteLinkBrowser.js:103:9
    PageLinkHandler.linkPage https://.../typo3/sysext/recordlist/Resources/Public/JavaScript/PageLinkHandler.js:40:3
    dispatch https://.../typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery/jquery-2.1.4.min.js:3:6414
    add/r.handle https://.../typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery/jquery-2.1.4.min.js:3:3224

Associated revisions

Revision 32f18c87 (diff)
Added by Benni Mack about 1 year ago

[BUGFIX] HtmlArea: Use getAttribute() directly

RTE HtmlArea uses getAttributeNode() for gecko
browsers, however this is deprecated in current
Firefox versions.

To just get the value of an attribute getAttribute()
can be used instead:

See the usages here:
- https://www.w3schools.com/jsref/met_element_getattributenode.asp
- https://www.w3schools.com/jsref/met_element_getattribute.asp

Resolves: #80934
Releases: 7.6
Change-Id: Ic3962ad7339a56c8d0e7b94a8aaba27a56744bf8
Reviewed-on: https://review.typo3.org/52814
Tested-by: TYPO3com <>
Reviewed-by: Riccardo De Contardi <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52814

#2 Updated by Benni Mack about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF