Project

General

Profile

Actions

Task #81020

closed

[Root line] Remove the feature to preload relations from the root line

Added by Elmar Hinz over 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-04-26
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Remove the feature to preload relations from the root line

Issue

The method RootlineUtility:enrichWithRelationFields() preloads relations for each page.

This causes a bunch of additional DB queries per page request.

Discussion

  • The feature is rarely used while the costs are rather high.
  • There are several comments on unclean implementation.
  • No unit tests are breaking if the feature is removed.
  • The official introduction package keeps working, if the feature is removed.

Alternatives

  • Load the information on demand.
  • Think of an intelligent design of page record objects, that enable loading on demand or by configuration.
Actions #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52610

Actions #2

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52610

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52610

Actions #4

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52610

Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52610

Actions #6

Updated by Riccardo De Contardi almost 7 years ago

  • Status changed from Under Review to Closed
  • Assignee deleted (Elmar Hinz)

I close this issue - the ticket has been abandoned since long time

If you think that this is the wrong decision or that there is still work to be done, please reopen it or open a new issue with a reference to this one. Thank you.

Actions

Also available in: Atom PDF