Bug #81039

buildRepresentationForNode function doesn't scale.

Added by Christer V over 2 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2017-04-27
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The code in buildRepresentationForNode doesn't scale since it sorts the entire list after each append.

Associated revisions

Revision 359a8881 (diff)
Added by Christer V over 2 years ago

[BUGFIX] Do not sort tree nodes after each append

Nodes should not be sorted after each element append but only once at
the end.

This will reduce the execution time of
DatabaseTreeDataProvider::buildRepresentationForNode() a lot e.g. when
a category menu tree is generated.

Resolves: #81039
Releases: master, 8.7
Change-Id: I9cb57630f0179a0b2b3c921ca1eb97e7455ce962
Reviewed-on: https://review.typo3.org/52631
Reviewed-by: Sascha Egerer <>
Tested-by: Sascha Egerer <>
Tested-by: TYPO3com <>
Reviewed-by: Christer V <>
Tested-by: Christer V <>
Reviewed-by: Anders Kostending <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

Revision 8c27876a (diff)
Added by Christer V over 2 years ago

[BUGFIX] Do not sort tree nodes after each append

Nodes should not be sorted after each element append but only once at
the end.

This will reduce the execution time of
DatabaseTreeDataProvider::buildRepresentationForNode() a lot e.g. when
a category menu tree is generated.

Resolves: #81039
Releases: master, 8.7
Change-Id: I9cb57630f0179a0b2b3c921ca1eb97e7455ce962
Reviewed-on: https://review.typo3.org/52729
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>
Tested-by: TYPO3com <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52631

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52631

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52631

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52631

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52631

#6 Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52631

#7 Updated by Benni Mack over 2 years ago

  • Target version changed from 8 LTS to next-patchlevel

#8 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52729

#9 Updated by Christer V over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF