Bug #81757

EXT:Fluid UriViewHelper needs escapeOutput = false;

Added by Aljoscha Weber over 1 year ago. Updated over 1 year ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2017-06-30
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

The escapeOutput property of the TYPO3\CMS\Fluid\ViewHelpers\Widget\UriViewHelper should be set to false or the generated link will be wrong in the autocomplete-ViewHelper.

Current-Output of the TYPO3\CMS\Fluid\ViewHelpers\Widget\AutocompleteViewHelper:

{f:widget.uri(action:'autocomplete', ajax: 1)}

?id=15&type=7076&fluid-widget-id=59640106e78e5b3eceab2d0a402a98a4&action=autocomplete

Output with escapeOutput = false;

?id=15&type=7076&fluid-widget-id=3530c7af3431d73ca17d4e0fdd691a0b&action=autocomplete

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53368

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53369

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53369

#4 Updated by Aljoscha Weber over 1 year ago

This is still broken in 8.7.5. Adding:

    /**
     * As this ViewHelper renders HTML, the output must not be escaped.
     *
     * @var bool
     */
    protected $escapeOutput = false;

like in the patch set fixes the problem.

#5 Updated by Aljoscha Weber over 1 year ago

  • Complexity set to no-brainer

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53369

Also available in: Atom PDF