Bug #82916

Catch viewhelper exceptions and log them in production context

Added by Sascha Egerer about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Fluid
Target version:
Start date:
2017-11-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:
Remote Sprint

Description

Exceptions are currently not catched at the correct place.
Instead of logging them they are partially silenty ignored and you will not find a reason why an image tag is broken like in the ImageViewHelper.

There is already some code that should log thrown exceptions and ignore them in production context but that code does not work as instead of catching \Exception only Exception is catched which does not exist at all in that namespace.


Related issues

Related to TYPO3 Core - Bug #82918: Do not silently ignore exceptions in image viewhelperClosedSascha Egerer2017-11-03

Actions
#1

Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54550

#2

Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54550

#3

Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54550

#4

Updated by Sascha Egerer about 3 years ago

  • Status changed from Under Review to Closed

That does work. Just missed an existing class alias map.

#5

Updated by Frans Saris about 3 years ago

  • Related to Bug #82918: Do not silently ignore exceptions in image viewhelper added

Also available in: Atom PDF