Project

General

Profile

Actions

Bug #82918

closed

Do not silently ignore exceptions in image viewhelper

Added by Sascha Egerer over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Fluid
Target version:
Start date:
2017-11-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

Exceptions that an image could not be rendered must not be silently ignored but thrown or logged in the production context

If you add for example this viewhelper <f:image src="http://test.com/image.jpg" /> (yes that wont work but i also wonder why it is not possible to add a url to an image and then just render it) you'll get an <img /> tag and thats it. No logging - no information about a broken image tag.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #71686: Image ViewHelper throws excpetion if image is missingClosedAndreas Allacher2015-11-19

Actions
Related to TYPO3 Core - Bug #82916: Catch viewhelper exceptions and log them in production contextClosedSascha Egerer2017-11-03

Actions
Actions #1

Updated by Sascha Egerer over 6 years ago

  • Sprint Focus set to Remote Sprint
Actions #2

Updated by Sascha Egerer over 6 years ago

  • Description updated (diff)
Actions #3

Updated by Sascha Egerer over 6 years ago

  • Parent task deleted (#82916)
Actions #4

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54561

Actions #5

Updated by Frans Saris over 6 years ago

  • Related to Bug #71686: Image ViewHelper throws excpetion if image is missing added
Actions #6

Updated by Frans Saris over 6 years ago

  • Related to Bug #82916: Catch viewhelper exceptions and log them in production context added
Actions #7

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54561

Actions #8

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54561

Actions #9

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54561

Actions #10

Updated by Sascha Egerer over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF