Bug #82918

Do not silently ignore exceptions in image viewhelper

Added by Sascha Egerer about 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Fluid
Target version:
Start date:
2017-11-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

Exceptions that an image could not be rendered must not be silently ignored but thrown or logged in the production context

If you add for example this viewhelper <f:image src="http://test.com/image.jpg" /> (yes that wont work but i also wonder why it is not possible to add a url to an image and then just render it) you'll get an <img /> tag and thats it. No logging - no information about a broken image tag.


Related issues

Related to TYPO3 Core - Bug #71686: Image ViewHelper throws excpetion if image is missingClosedAndreas Allacher2015-11-19

Actions
Related to TYPO3 Core - Bug #82916: Catch viewhelper exceptions and log them in production contextClosedSascha Egerer2017-11-03

Actions
#1

Updated by Sascha Egerer about 3 years ago

  • Sprint Focus set to Remote Sprint
#2

Updated by Sascha Egerer about 3 years ago

  • Description updated (diff)
#3

Updated by Sascha Egerer about 3 years ago

  • Parent task deleted (#82916)
#4

Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54561

#5

Updated by Frans Saris about 3 years ago

  • Related to Bug #71686: Image ViewHelper throws excpetion if image is missing added
#6

Updated by Frans Saris about 3 years ago

  • Related to Bug #82916: Catch viewhelper exceptions and log them in production context added
#7

Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54561

#8

Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54561

#9

Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54561

#10

Updated by Sascha Egerer about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF