Bug #82921

FIx notices in page module rendering

Added by Tymoteusz Motylewski almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2017-11-05
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

During rendering of the page module in backend there are plenty of notices being thrown.


Related issues

Related to TYPO3 Core - Bug #84868: wrong check for key existance in getPageForRootline Closed 2018-04-25

Associated revisions

Revision 5b5336f6 (diff)
Added by Tymoteusz Motylewski almost 2 years ago

[BUGFIX] Fix some PHP Notices thrown when rendering page module

Resolves: #82921
Releases: master, 8.7
Change-Id: Id26239e65321aa3653de849932a0be7e626bd653
Reviewed-on: https://review.typo3.org/54558
Tested-by: TYPO3com <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision 690204a3 (diff)
Added by Tymoteusz Motylewski almost 2 years ago

[BUGFIX] Fix some PHP Notices thrown when rendering page module

Resolves: #82921
Releases: master, 8.7
Change-Id: Id26239e65321aa3653de849932a0be7e626bd653
Reviewed-on: https://review.typo3.org/54658
Tested-by: TYPO3com <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

Revision e950ebed (diff)
Added by Jan Helke almost 2 years ago

[FOLLOWUP][BUGFIX] Fix some PHP Notices thrown rendering page module

Refer to the correct LanguageService.
The referenced class is not present in TYPO3 version 8.

Related: #82921
Releases: 8.7
Change-Id: Id68086149170d73e3251beba3653344660f4c55c
Reviewed-on: https://review.typo3.org/54745
Tested-by: TYPO3com <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 15c917a2 (diff)
Added by Tymoteusz Motylewski over 1 year ago

[BUGFIX] Correctly check for a key in getPageForRootline

Move coalescing operator to inside is_array. It was was introduced
in https://review.typo3.org/#/c/54558/

Releases: master, 8.7
Resolves: #84868
Related: #82921
Change-Id: I54e60cd3fbd2ab36e945cd2e2ed9c6fc02a5bf5a
Reviewed-on: https://review.typo3.org/56804
Reviewed-by: Wouter Wolters <>
Tested-by: TYPO3com <>
Reviewed-by: Riny van Tiggelen <>
Reviewed-by: Guido Schmechel <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Tymoteusz Motylewski almost 2 years ago

  • Description updated (diff)

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54558

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54558

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54558

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54558

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54558

#7 Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54558

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54558

#9 Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54558

#10 Updated by Tymoteusz Motylewski almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54658

#12 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54658

#13 Updated by Tymoteusz Motylewski almost 2 years ago

  • Status changed from Under Review to Resolved

#14 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54745

#15 Updated by Tymoteusz Motylewski over 1 year ago

  • Related to Bug #84868: wrong check for key existance in getPageForRootline added

#16 Updated by Tymoteusz Motylewski over 1 year ago

  • Status changed from Under Review to Closed

Also available in: Atom PDF