Bug #83958

Writing extension configuration removes configuration

Added by Nicole Cordes about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2018-02-18
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Calling \TYPO3\CMS\Core\Core\Bootstrap::populateLocalConfiguration() within \TYPO3\CMS\Core\Configuration\ExtensionConfiguration::set and \TYPO3\CMS\Core\Configuration\ExtensionConfiguration::setAll removes configuration from loaded extensions.
This results in unavailable keys and settings. See https://travis-ci.org/TYPO3-Console/TYPO3-Console/jobs/342527386#L731

Associated revisions

Revision 94a5a0f9 (diff)
Added by Nicole Cordes about 2 years ago

[BUGFIX] Prevent repopulating TYPO3_CONF_VARS

Instead of using the native API when changing a TYPO3 Extension
configuration through the new ExtensionConfiguration API, the
method is now solely overwriting the global $TYPO3_CONF_VARS[EXTENSIONS]
and $TYPO3_CONF_VARS[EXT][extConf] options during runtime
to avoid deadlocks and to avoid the removal of existing configuration
of extensions.

The second parameter of ExtensionConfiguration->set() can be removed
separately once EXT:bootstrap_package is adapted to the new functionaliy.

Resolves: #83958
Resolves: #83954
Releases: master
Change-Id: Icc8a3482edaef1ea329e68638d5ef467548062fc
Reviewed-on: https://review.typo3.org/55703
Tested-by: TYPO3com <>
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>
Reviewed-by: Alexander Opitz <>
Tested-by: Alexander Opitz <>

Revision 349a7fa4 (diff)
Added by Benjamin Franzke about 2 years ago

[TASK] Do not repopulate $GLOBALS['TYPO3_CONF_VARS'] in installer

This is a followup for Icc8a3482edaef1ea329e68638d5ef467548062fc
which missed to remove the TYPO3_CONF_VARS repopulation
from the installer controller.

Now that ExtensionConfiguration::set() updates changed properties,
the manual repopulation after calling
synchronizeExtConfTemplateWithLocalConfigurationOfAllExtensions()
is not needed anymore and should be removed for the same
reasons as described in the mentioned change.

Change-Id: I3ff24411d2f0807a09c49d19bc021e9a239e6cb0
Releases: master
Resolves: #83954
Related: #83958
Reviewed-on: https://review.typo3.org/55778
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Tobi Kretschmann <>
Tested-by: Tobi Kretschmann <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55703

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55703

#3 Updated by Nicole Cordes about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF