Actions

Copy link

Bug #84052

closed

MenuProcessor does not respect default page target configuration

Added by Cyril Janody over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Frontend

Target version:

Candidate for patchlevel

Start date:

2018-02-26

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.1

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

How to reproduce¶

Create a page tree containing external links

Add TypoScript

config {
  intTarget =
  extTarget = _blank
  fileTarget = _blank
}

Define a menu

lib.menu = FLUIDTEMPLATE
lib.menu {
  file = EXT:.....Menu.html

  dataProcessing {
    10 = TYPO3\CMS\Frontend\DataProcessing\MenuProcessor
    10 {
      entryLevel = 0
      levels = 1
      titleField = nav_title // title
      as = menu
    }
  }
}

Debug template menu

<ul>
    <f:for each="{menu}" as="page">
        <li>
            <f:debug>{page}</f:debug>
        </li>
    </f:for>
</ul>

Target is empty... but it should not, right ?!

Thanks for reading.

Files

78151.diff (887 Bytes) 78151.diff

Cyril Janody, 2018-03-01 19:48

Actions

Copy link

Updated by Frédéric Lebel over 6 years ago

Complexity set to no-brainer

The bug was fixed in 7.x, and 9.x but not in 8.x.

On the line 1640 in typo3\sysext\frontend\Classes\ContentObject\Menu\AbstractMenuContentObject.php, the following lines are missing :

if((empty($LD['target']) && !empty($this->getTypoScriptFrontendController()->extTarget))) {
                    $LD['target'] = $this->getTypoScriptFrontendController()->extTarget;
                }

ref. : https://forge.typo3.org/issues/78151

Actions

Copy link

Updated by Cyril Janody over 6 years ago

File 78151.diff 78151.diff added
Target version set to Candidate for patchlevel

Hi, here is a patch for TYPO3 8.7 ! ;)

Actions

Copy link

Updated by Guido S. over 6 years ago

Hi Cyril,

i can verify your patch with 8.7.12. Maybe you feel like apply the patch? TYPO3 documentation: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Index.html

If you have no time or something else, let me know. Then I add the patch.

Best, Guido

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from New to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56447

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56448

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56449

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56447

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56447

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56447

Actions

Copy link

#10