Bug #85082

Extbase translation tests don't fulfill expectations

Added by Nicole Cordes over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Nicole Cordes
Category:
Extbase
Target version:
-
Start date:
2018-05-25
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The Extbase TranslationTest should be executed in frontend mode. A mock of the EnvironmentService is infiltrated into the GeneralUtility to be used as singleton instance. Unfortunately the whole setUpBasicFrontendEnvironment method is called after the subject (PostRepository) was initiliazed by the ObjectManager. This early initialization doesn't know the mock and generates its own EnvironmentService singleton instance.

The tests and their expectations don't use the EnvironmentServiceMock and run in another mode (backend).

Associated revisions

Revision 0927abdd (diff)
Added by Nicole Cordes over 1 year ago

[BUGFIX] Ensure Extbase translation tests fulfill expectations

Ensure the test is executed as expected.

Resolves: #85082
Releases: master, 8.7
Change-Id: Ia0dfbdc12eeefbb28996f69dade4298b1464afa6
Reviewed-on: https://review.typo3.org/57050
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Tested-by: Markus Klein <>

Revision b83b7b85 (diff)
Added by Nicole Cordes over 1 year ago

[BUGFIX] Ensure Extbase translation tests fulfill expectations

Ensure the test is executed as expected.

Resolves: #85082
Releases: master, 8.7
Change-Id: Ia0dfbdc12eeefbb28996f69dade4298b1464afa6
Reviewed-on: https://review.typo3.org/57053
Tested-by: TYPO3com <>
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57050

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57053

#3 Updated by Nicole Cordes over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF