Task #85116

Change visibility of CharsetConverter init methods

Added by Benni Mack about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2018-05-30
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision ab71719b (diff)
Added by Benni Mack about 1 year ago

[TASK] Change visibility of CharsetConverter init methods

Various CharsetConverter methods are there for initialization conversion,
which are marked as @private and are only used within the class.

The patch switches the method signatures from public to protected.

The following methods are affected:
- initCharset()
- initUnicodeData()
- initCaseFolding()
- initToASCII()

Resolves: #85116
Releases: master
Change-Id: I153123068cbfbf0baee729aab7dc0946913d5d7c
Reviewed-on: https://review.typo3.org/57088
Reviewed-by: Mathias Brodala <>
Tested-by: TYPO3com <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Wouter Wolters <>
Tested-by: Mathias Brodala <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57088

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57088

#3 Updated by Benni Mack about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF