Bug #85243
closed
stuck in infinite loop when deleting a file
0%
Description
i use a S3 FAL Driver and it gets stuck in this infinite loop when trying to delete a file. i posted a issue there, https://github.com/andersundsehr/aus_driver_amazon_s3/issues/36
but now i think its this error here, i noticed the error when updating from 8.7.15 to 8.7.16 and should also be here in master.
line 3082: to me it doesnt make ANY sense that the identifier of the parent is the same as the folder itself thus, the do while loop never exits. i hope my PR is the fix and doesnt break anything. it looks fine for me in 8.7.16
i also think its bad practice to use do while loops because its very easy to make a mistake and get stuck in the loop and also i found this very hard to understand and so it took me quite a while to understand this code, especially the isFolderLoop condition.
This issue was automatically created from https://github.com/TYPO3/TYPO3.CMS/pull/113
Updated by Gerrit Code Review almost 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57203
Updated by Simon Gilli almost 6 years ago
- Tracker changed from Task to Bug
- Category set to File Abstraction Layer (FAL)
- Target version set to 8.7.19
- Is Regression set to Yes
Updated by Simon Gilli almost 6 years ago
- Related to Bug #85079: You are not allowed to access the given folder: "user_upload" added
Updated by Gerrit Code Review almost 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57203
Updated by Gerrit Code Review almost 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57203
Updated by Simon Gilli almost 6 years ago
- Status changed from Under Review to Closed
- Target version deleted (
8.7.19) - Is Regression deleted (
Yes)
Finally the problem has been identified as a bug in the AWS S3 driver (https://github.com/andersundsehr/aus_driver_amazon_s3/blob/master/Classes/Driver/AmazonS3Driver.php) so will close this issue.