Project

General

Profile

Actions

Bug #85243

closed

stuck in infinite loop when deleting a file

Added by Forger Service almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2018-06-12
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

i use a S3 FAL Driver and it gets stuck in this infinite loop when trying to delete a file. i posted a issue there, https://github.com/andersundsehr/aus_driver_amazon_s3/issues/36

but now i think its this error here, i noticed the error when updating from 8.7.15 to 8.7.16 and should also be here in master.

line 3082: to me it doesnt make ANY sense that the identifier of the parent is the same as the folder itself thus, the do while loop never exits. i hope my PR is the fix and doesnt break anything. it looks fine for me in 8.7.16

i also think its bad practice to use do while loops because its very easy to make a mistake and get stuck in the loop and also i found this very hard to understand and so it took me quite a while to understand this code, especially the isFolderLoop condition.
This issue was automatically created from https://github.com/TYPO3/TYPO3.CMS/pull/113


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #85079: You are not allowed to access the given folder: "user_upload"ClosedNicole Cordes2018-05-25

Actions
Actions

Also available in: Atom PDF