Bug #85249

AbstractHierarchicalFilesystemDriver->getParentFolderIdentifierOfIdentifier fails on Windows

Added by Nicole Cordes about 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2018-06-13
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Given:

- Windows system
- any third-party driver extending \TYPO3\CMS\Core\Resource\Driver\AbstractHierarchicalFilesystemDriver (e.g. aus_driver_amazon_s3)

Expectation:

- parent folder can be fetched by using \TYPO3\CMS\Core\Resource\Driver\AbstractHierarchicalFilesystemDriver::getParentFolderIdentifierOfIdentifier

Actual:

- PathUtility::dirname returns a path with Windows directory separator
- file identifier are expected to use slashes
- root identifier currently returns double slashes

Associated revisions

Revision 1b2670c5 (diff)
Added by Nicole Cordes 10 months ago

[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver

This patch ensures that
AbstractHierarchicalFilesystemDriver::getParentFolderIdentifierOfIdentifier
always returns a file identifier using forward slashes. Furthermore
it removes double forward slashes for a root folder identifier.

Resolves: #85249
Releases: master, 8.7
Change-Id: I562eaade7353e5235d4f65725a4159f6c0b71d75
Reviewed-on: https://review.typo3.org/57207
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Susanne Moog <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision cb7a5187 (diff)
Added by Nicole Cordes 10 months ago

[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver

This patch ensures that
AbstractHierarchicalFilesystemDriver::getParentFolderIdentifierOfIdentifier
always returns a file identifier using forward slashes. Furthermore
it removes double forward slashes for a root folder identifier.

Resolves: #85249
Releases: master, 8.7
Change-Id: I562eaade7353e5235d4f65725a4159f6c0b71d75
Reviewed-on: https://review.typo3.org/58757
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57207

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57207

#3 Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58757

#4 Updated by Nicole Cordes 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF