Project

General

Profile

Actions

Bug #85580

closed

Wrong call of method getRecordsToCopyDatabaseResult from Localisation Controller

Added by Martin Horniak over 6 years ago. Updated over 6 years ago.

Status:
Rejected
Priority:
Must have
Assignee:
-
Category:
Localization
Target version:
Start date:
2018-07-17
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

In the LocalisationController in the Method getRecordUidsToCopy is a call to the Repository Method getRecordsToCopyDatabaseResult w2ith wrong number of arguments.
The definition of the calling Method has five arguments, where as fifth argument is a field list. But in the calee Method is 'uid' string as fourth argument used.

LocalisationController::getRecordLocalizeSummary (right call):

$result = $this->localizationRepository->getRecordsToCopyDatabaseResult(
            $params['pageId'],
            $params['colPos'],
            $params['destLanguageId'],
            $params['languageId'],
            '*'
        );

LocalisationController::getRecordUidsToCopy (wrong call):

$result = $this->localizationRepository->getRecordsToCopyDatabaseResult($pageId, $colPos, $languageId, 'uid');

Definition:

public function getRecordsToCopyDatabaseResult($pageId, $colPos, $destLanguageId, $languageId, $fields = '*')

Actions #1

Updated by Martin Horniak over 6 years ago

Is already existing in TYPO3 version 7. Has anyone noticed so far?
In the Version 9 has the definition (and the localisation call too) four arguments only and method for copy is no more present.

Actions #2

Updated by Andreas Kienast over 6 years ago

  • Status changed from New to Rejected

Thanks for the report.

I took a look at the code and I came to the conclusion we won't solve this issue.
The method is removed in v9, deprecated in v8 and not used at all in v7, otherwise the defect would have been discovered earlier.

Actions

Also available in: Atom PDF