Project

General

Profile

Actions

Bug #85873

closed

Typolink not contains port on absolute URIs only, if sys_domain includes port

Added by Julian Wundrak over 5 years ago. Updated over 5 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
-
Start date:
2018-08-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

Generation of an absolute TypoLink with a non-standard port fails (On TYPO3 7.6 it works as excepted).

In 7.6 there was an additional check (ContentObjectRenderer)

$tsfe->config['config']['typolinkCheckRootline']

that not on our Installation not matched and so target domain is set to current domain here:

// If no domain records are defined, use current domain:
$currentUrlScheme = parse_url($this->getEnvironmentVariable('TYPO3_REQUEST_URL'), PHP_URL_SCHEME);
if ($targetDomain === '' && ($conf['forceAbsoluteUrl'] || $absoluteUrlScheme !== $currentUrlScheme)) {
     $targetDomain = $currentDomain;
}

As result: $currentDomain and $targetDomain are equals and contains the port.

In 8.7 and 9.x the typolinkCheckRootline was removed in PageLinkBuilder, so currentDomain set to the sys_domain-Record, which should not contains the port. This means, that $currentDomain != $targetDomain, so PageLinkBuilder build the url, but missed the port

Actions #1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57929

Actions #2

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57929

Actions #3

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57929

Actions #4

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57929

Actions #5

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57929

Actions #6

Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57929

Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Under Review to Rejected
Actions

Also available in: Atom PDF