Task #86046

Inject PSR-7 data in TSFE methods

Added by Benni Mack over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Frontend
Target version:
Start date:
2018-08-30
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #86241: config.defaultGetVars does not populate the middleware's request object Closed 2018-09-13

Associated revisions

Revision c3377631 (diff)
Added by Benni Mack over 1 year ago

[TASK] Inject PSR-7 data in TSFE methods

The following public methods within TSFE now get a PSR-7 request object
handed in to fetch the GET / POST variables.

- $TSFE->preparePageContentGeneration(ServerRequestInterface $request)
- $TSFE->calculateLinkVars(array $queryParams)
- $TSFE->makeCacheHash()

Note: If a hook modified _GET and preparePageContentGeneration
is called from Core, the state of _GET and $request->getQueryParams()
will differ. This COULD be overcome by using GeneralUtility::_GETset()
which TYPO3 Core and extensions like realurl already use.

Resolves: #86046
Releases: master
Change-Id: Iecb333d1b501c0d14abf4d16d930e715e9bd8d2e
Reviewed-on: https://review.typo3.org/58093
Tested-by: TYPO3com <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 76d1c9c4 (diff)
Added by Benni Mack over 1 year ago

[BUGFIX] Evaluate config.defaultGetVars in middleware

The config.defaultGetVars is executed and $_GET is modified,
but not the middleware where this method is called.

In order to also modify the middleware's request object, the
option config.defaultGetVars is also evaluted again in the PSR-15
middleware.

Resolves: #86241
Related: #86046
Releases: master
Change-Id: I2238d93b4974a40b2228c099cef7c8a04bd6cf74
Reviewed-on: https://review.typo3.org/58266
Tested-by: TYPO3com <>
Reviewed-by: Daniel Sattler <>
Tested-by: Daniel Sattler <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58093

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58093

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58093

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58093

#5 Updated by Benni Mack over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack over 1 year ago

  • Related to Bug #86241: config.defaultGetVars does not populate the middleware's request object added

#7 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF