Task #86138

Use filterNumericIds as real filter method in DataMapProcessor

Added by Nicole Cordes over 1 year ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2018-09-04
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Currently there is an option in \TYPO3\CMS\Core\DataHandling\Localization\DataMapProcessor::filterNumericIds to filter ids and either return an array with elements that have a numeric id or to return an array with items that have no numeric id. This option is not needed and the method should always return what it is intended to return. If you need an array with non-numeric ids, you can simply calculate the offset of all items and the filtered once.

Associated revisions

Revision 6319bd57 (diff)
Added by Nicole Cordes 2 months ago

[TASK] Prevent superfluous filters in DataMapProcessor

For consistency in the filterNumericIds method of DataMapProcessor,
there should only be one result be returned. This patch removes the
second parameter to invert the methods behaviour.

Resolves: #86138
Releases: master
Change-Id: I89bd4949e75818a26dd23c0884ccc0cf41401804
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58048
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Oliver Hader <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Benni Mack <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58048

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58048

#3 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58048

#4 Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58048

#5 Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58048

#6 Updated by Nicole Cordes 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF