Task #86138

Use filterNumericIds as real filter method in DataMapProcessor

Added by Nicole Cordes almost 3 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2018-09-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Currently there is an option in \TYPO3\CMS\Core\DataHandling\Localization\DataMapProcessor::filterNumericIds to filter ids and either return an array with elements that have a numeric id or to return an array with items that have no numeric id. This option is not needed and the method should always return what it is intended to return. If you need an array with non-numeric ids, you can simply calculate the offset of all items and the filtered once.

#1

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58048

#2

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58048

#3

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58048

#4

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58048

#5

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58048

#6

Updated by Nicole Cordes over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
#8

Updated by Gerrit Code Review about 1 month ago

  • Status changed from Closed to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69033

#9

Updated by Nicole Cordes about 1 month ago

  • Status changed from Under Review to Resolved
#10

Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF