Bug #86152

wrong column label in drawOverrideModal dialog

Added by Rainer Plöckl over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-09-05
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

there is mismatch of the labeling in the DragUopload.js when the overwrite dialogue (drawOverrideModal) appears.

The labels for columns are specified as:
$('<th/>').text(TYPO3.lang['file_upload.header.originalFile']),
$('<th/>').text(TYPO3.lang['file_upload.header.uploadedFile']),

but the ordering for the file details are later in the opposite order, first the uploaded and then the original.

askForOverride[i].uploaded.name + ' (' + (DragUploader.fileSizeAsString(askForOverride[i].uploaded.size)) + ')' +
'<br>' + moment(askForOverride[i].uploaded.lastModified, 'x').format('YYYY-MM-DD HH:mm')
),
$('<td />').html(
askForOverride[i].uploaded.name + ' (' +
(DragUploader.fileSizeAsString(askForOverride[i].original.size)) + ')' +
'<br>' + moment(askForOverride[i].original.mtime, 'X').format('YYYY-MM-DD HH:mm')

Seen in Typo3 8.7.*

Associated revisions

Revision dcf1dc21 (diff)
Added by Andreas Fernandez over 1 year ago

[BUGFIX] Use correct column order in override dialog

Resolves: #86152
Releases: master, 8.7
Change-Id: I677c6d0405b833caf8a62f7f560b2e9b97679b36
Reviewed-on: https://review.typo3.org/58389
Tested-by: TYPO3com <>
Reviewed-by: Josef Glatz <>
Tested-by: Josef Glatz <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

Revision f7a1c385 (diff)
Added by Andreas Fernandez over 1 year ago

[BUGFIX] Use correct column order in override dialog

Resolves: #86152
Releases: master, 8.7
Change-Id: I677c6d0405b833caf8a62f7f560b2e9b97679b36
Reviewed-on: https://review.typo3.org/58390
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

History

#1 Updated by Stephan Großberndt over 1 year ago

  • Project changed from forge.typo3.org to TYPO3 Core
  • TYPO3 Version set to 8

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58389

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58390

#4 Updated by Andreas Fernandez over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF