Project

General

Profile

Actions

Bug #86152

closed

wrong column label in drawOverrideModal dialog

Added by Rainer Plöckl over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-09-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

there is mismatch of the labeling in the DragUopload.js when the overwrite dialogue (drawOverrideModal) appears.

The labels for columns are specified as:
$('<th/>').text(TYPO3.lang['file_upload.header.originalFile']),
$('<th/>').text(TYPO3.lang['file_upload.header.uploadedFile']),

but the ordering for the file details are later in the opposite order, first the uploaded and then the original.

askForOverride[i].uploaded.name + ' (' + (DragUploader.fileSizeAsString(askForOverride[i].uploaded.size)) + ')' +
'<br>' + moment(askForOverride[i].uploaded.lastModified, 'x').format('YYYY-MM-DD HH:mm')
),
$('<td />').html(
askForOverride[i].uploaded.name + ' (' +
(DragUploader.fileSizeAsString(askForOverride[i].original.size)) + ')' +
'<br>' + moment(askForOverride[i].original.mtime, 'X').format('YYYY-MM-DD HH:mm')

Seen in Typo3 8.7.*

Actions #1

Updated by Stephan Großberndt over 5 years ago

  • Project changed from 9 to TYPO3 Core
  • TYPO3 Version set to 8
Actions #2

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58389

Actions #3

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58390

Actions #4

Updated by Andreas Fernandez over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF