Task #86170

Check for extbase response type instead of current environment

Added by Daniel Siepmann 12 months ago. Updated 30 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2018-09-06
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
7.0
Tags:
Complexity:
Sprint Focus:

Description

It's currently not possible to run functional tests that expect frontend output of Extbase.
Extbase will check for current environment to be CLI context, which is true for functional tests.
Still the response might be a web Response which does not implement the called method.

This issue occurs in 7, 8 and master.

Associated revisions

Revision c399a2e1 (diff)
Added by Daniel Siepmann 10 months ago

[TASK] Check for Extbase response type instead of environment

Functional tests always set CLI context to true. Even if Extbase returns
an Web\Response, the method getExitCode will be called, which only
exists in Cli\Response.

Therefore a check against the response type allows to run functional
tests with Web\Response in Extbase.

Resolves: #86170
Releases: master
Change-Id: I5982d77aad82f92b6e6bb13cca5118ea2a3e7796
Reviewed-on: https://review.typo3.org/58200
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review 12 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58200

#2 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58200

#3 Updated by Daniel Siepmann 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 30 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF