Bug #86599

PHP Warning when calling /?eID=dumpFile

Added by Sascha Egerer 2 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2018-10-09
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:
Remote Sprint

Description

In /typo3/sysext/core/Classes/Controller/FileDumpController.php:57 a null value may be passed to the hash_equals function if no token parameter is given.

Steps to reproduce:
Open https://yoursite.tld/?eID=dumpFile

PHP Warning: hash_equals(): Expected user_string to be a string, null given in /var/www/public/typo3/sysext/core/Classes/Controller/FileDumpController.php line 57

Associated revisions

Revision e52a91c8 (diff)
Added by Sascha Egerer about 2 months ago

[BUGFIX] Prevent null value being passed to hash_equals

The second parameter of hash_equals must be a string but could be a
null value in the FileDumpController. It is ensured now that the
value is always a string.

Resolves: #86599
Releases: master, 8.7
Change-Id: Iaf682b405be6712aa31603521a2d873b4c3bcb89
Reviewed-on: https://review.typo3.org/58596
Tested-by: TYPO3com <>
Reviewed-by: Mathias Brodala <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 59ed7aa9 (diff)
Added by Benni Mack about 2 months ago

[BUGFIX] Prevent null value being passed to hash_equals

The second parameter of hash_equals must be a string but could be a
null value in the FileDumpController. It is ensured now that the
value is always a string.

Resolves: #86599
Releases: master, 8.7
Change-Id: Iaf682b405be6712aa31603521a2d873b4c3bcb89
Reviewed-on: https://review.typo3.org/58713
Reviewed-by: Oliver Klee <>
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58596

#2 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58596

#3 Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58596

#4 Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58596

#5 Updated by Gerrit Code Review about 2 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58713

#6 Updated by Sascha Egerer about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF