Bug #87668

Revert "ExtbasePluginEnhancer does not use a custom controller configuration"

Added by Benni Mack 10 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Link Handling, Site Handling & Routing
Start date:
2019-02-07
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The accepted change adds some nasty sideffects so the same controller/action cannot be used in two routes anymore.


Related issues

Related to TYPO3 Core - Bug #87337: ExtbasePluginEnhancer does not use a custom controller configuration Resolved 2019-01-05

Associated revisions

Revision 0615ba7c (diff)
Added by Benni Mack 10 months ago

[BUGFIX] Revert Set controller in ExtbasePluginEnhancer"

The accepted change adds an ugly side-effect when using
the same controller/action in multiple route variants.

This reverts commit 977ed578d04a3c2094cdad3207b5d9f86322f326.

Resolves: #87668
Reverts: #87337
Releases: master, 9.5

Change-Id: I7167b42cb26538e676256c9d2e36d1ec18f2bd40
Reviewed-on: https://review.typo3.org/59658
Tested-by: TYPO3com <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 2e8a1911 (diff)
Added by Oliver Hader 10 months ago

[BUGFIX] Revert Set controller in ExtbasePluginEnhancer"

The accepted change adds an ugly side-effect when using
the same controller/action in multiple route variants.

This reverts commit 3b11984b1f177093eda423072dd5dc689d9f721f.

Resolves: #87668
Reverts: #87337
Releases: master, 9.5
Change-Id: Ic98bf86a2646b2e7506db3efc8a14c8bd0b393e6
Reviewed-on: https://review.typo3.org/59660
Tested-by: TYPO3com <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Benni Mack 10 months ago

  • Related to Bug #87337: ExtbasePluginEnhancer does not use a custom controller configuration added

#2 Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59658

#3 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59658

#4 Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59660

#5 Updated by Benni Mack 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF