Bug #87871

pages in workspace URLs are not resolved

Added by Benni Mack 3 months ago. Updated 18 days ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Link Handling, Site Handling & Routing
Start date:
2019-03-09
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When generating links to a page that is modified,
or trying to find a slug that is modified in a versioned page,
this does not work.

1. The PageLinkBuilder tries to resolve a versioned page, and detects "pid=-1" and then fails to find the proper Site. That's why $page['t3ver_oid'] needs to be checked.
2. The PageRouter should include records with "-1" to find them as well, but then fix the "pid" again to find the pid of the online version.

Associated revisions

Revision b666df05 (diff)
Added by Benni Mack 2 months ago

[BUGFIX] Resolve and link modified slugs in workspaces properly

When a page (slug) is modified in a preview workspace,
links to that page need to be changed to the new slug, as the
preview (PageRouter) should evaluate this as well.

1) The PageRouter should include records with "-1"
to find them as well, but then fix the "pid" again to
find the pid of the online version.

2) The PageLink Builder now uses the SiteFinder nstead of SiteMatcher
to detect whether the linked page uid is part of a configured site.
We do not need to create/detect a PseudoSite here, only instances
of Site are of interest.

Resolves: #87871
Releases: master, 9.5
Change-Id: Ifd6add71bec1616049f8c6a50a42bc9f573395e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59955
Tested-by: Benjamin Franzke <>
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Benjamin Franzke <>
Reviewed-by: Oliver Hader <>

Revision f5cf5dc2 (diff)
Added by Benni Mack 2 months ago

[BUGFIX] Resolve and link modified slugs in workspaces properly

When a page (slug) is modified in a preview workspace,
links to that page need to be changed to the new slug, as the
preview (PageRouter) should evaluate this as well.

1) The PageRouter should include records with "-1"
to find them as well, but then fix the "pid" again to
find the pid of the online version.

2) The PageLink Builder now uses the SiteFinder nstead of SiteMatcher
to detect whether the linked page uid is part of a configured site.
We do not need to create/detect a PseudoSite here, only instances
of Site are of interest.

Resolves: #87871
Releases: master, 9.5
Change-Id: Ifd6add71bec1616049f8c6a50a42bc9f573395e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60332
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59955

#2 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59955

#3 Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59955

#4 Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59955

#5 Updated by Gerrit Code Review 2 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59955

#6 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60332

#7 Updated by Benni Mack 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack 18 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF