Task #87907

Remove unused code and streamline HMENU functionality

Added by Benni Mack 2 months ago. Updated 18 days ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Content Rendering
Start date:
2019-03-14
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision 840659af (diff)
Added by Benni Mack 2 months ago

[TASK] Remove and streamline HMENU functionality

HMENU was hardened during v9 via deprecations of
GMENU and making most of the properties protected.

Therefore, code can now refactored more easily.

- The method signatures for HMENU / TMENU are
streamlined.
- All leftover "RO" (RollOver) functionality is
removed (Breaking RST is already done but left-over
code was forgotten).
- Several GeneralUtility::inList() checks are replaced
with in_array()
- Some minor strict types for some internal obvious
methods
- use json_encode() instead of serialize()
for cache identifiers
- resolve some very very nested if() statements
- internal methods with "optional arguments" which
are always called with all arguments, are built
in a way that they are now non-optional.

Resolves: #87907
Releases: master
Change-Id: I80536b9b4dbc4609d38476c9ce48532fe71b73d0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60244
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Georg Ringer <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60244

#2 Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60244

#3 Updated by Benni Mack 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 18 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF