Bug #88246

ext:fluid Wrong Image View Helper argument description

Added by Daniel Corn 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2019-04-29
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

The description of the following View Helper arguments is wrong

- minHeight
- maxWidth
- maxHeight

Wrong in
https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php#l112

The problem does not exist in the URI Image View Helper

Associated revisions

Revision 312e4662 (diff)
Added by Jan Delius 5 months ago

[BUGFIX] Use correct ViewHelper argument description

Resolves: #88246
Releases: master, 9.5, 8.7
Change-Id: Iad8558cbe22caaefd659fef1681452a962b5cdf7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60620
Tested-by: Rico Drexler <>
Tested-by: Oliver Klee <>
Tested-by: Mathias Brodala <>
Tested-by: TYPO3com <>
Tested-by: Josef Glatz <>
Tested-by: Georg Ringer <>
Reviewed-by: Rico Drexler <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Mathias Brodala <>
Reviewed-by: Josef Glatz <>
Reviewed-by: Georg Ringer <>

Revision d6b7f940 (diff)
Added by Jan Delius 5 months ago

[BUGFIX] Use correct ViewHelper argument description

Resolves: #88246
Releases: master, 9.5, 8.7
Change-Id: Iad8558cbe22caaefd659fef1681452a962b5cdf7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60623
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Reviewed-by: Georg Ringer <>

Revision e09fe783 (diff)
Added by Jan Delius 5 months ago

[BUGFIX] Use correct ViewHelper argument description

Resolves: #88246
Releases: master, 9.5, 8.7
Change-Id: Iad8558cbe22caaefd659fef1681452a962b5cdf7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60624
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60620

#2 Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60620

#3 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60623

#4 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60624

#5 Updated by Jan Delius 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF