Bug #88356

Record Preview broken in 9.5.6

Added by Daniel Dorndorf about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
Start date:
2019-05-15
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
preview, record
Complexity:
Is Regression:
Sprint Focus:

Description

When building the paramaters for the preview url a condition checking the if a original version record is available seems to have syntactical issue.

in "typo3/sysext/backend/Classes/Controller/EditDocumentController.php:1032" the null coalesce operator seems to be a problem here. When having "versioningWS" true in your TCA the condition will be fullfilled even if "$recordArray['t3ver_oid'] > 0" is definetely false.

The only way fixing this would be to cut out the null coalesce assignment into a variable, then the if condition will work properly.

Greetings
Daniel

Associated revisions

Revision 617f0633 (diff)
Added by Daniel Dorndorf about 1 month ago

[BUGFIX] Fix record preview

A wrong evaluation of the null coalesce
assignment (?? is evaluted and && later-on),
the if() condition was always true for
any previews of records with versioning
enabled.

The Backend API is used instead.

Resolves: #88356
Releases: master, 9.5
Change-Id: I89ba14bd99bbeb17637b64d99a8d6de265a6e7c4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60758
Tested-by: Benni Mack <>
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Benni Mack <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Andreas Fernandez <>

Revision d37ac15b (diff)
Added by Daniel Dorndorf about 1 month ago

[BUGFIX] Fix record preview

A wrong evaluation of the null coalesce
assignment (?? is evaluted and && later-on),
the if() condition was always true for
any previews of records with versioning
enabled.

The Backend API is used instead.

Resolves: #88356
Releases: master, 9.5
Change-Id: I89ba14bd99bbeb17637b64d99a8d6de265a6e7c4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60759
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60758

#2 Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60758

#3 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60759

#4 Updated by Daniel Dorndorf about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF