Task #88674

Optimize ArrayUtility::replaceAndAppendScalarValuesRecursive()

Added by Simon Gilli 3 months ago. Updated 26 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Code Cleanup
Start date:
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

Optimize ArrayUtility::replaceAndAppendScalarValuesRecursive()


Related issues

Follows TYPO3 Core - Task #88652: Move YamlFileLoader->merge to ArrayUtillity Closed 2019-06-28
Precedes TYPO3 Core - Feature #88676: Introduce new methods of ArrayUtility as public API Closed 2019-07-02 2019-07-02

Associated revisions

Revision 003c5efd (diff)
Added by Simon Gilli 26 days ago

[TASK] Optimize and cleanup replaceAndAppendScalarValuesRecursive()

This optimizes ArrayUtility::replaceAndAppendScalarValuesRecursive() by
moving parts into new method hasStringKeys and removing other
duplicated code.

Resolves: #88674
Releases: master
Change-Id: Ieb0f57c330c400af94fc85bfd9af725cc8a8fe18
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215
Reviewed-by: Oliver Klee <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Frank Naegler <>
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Tested-by: Frank Naegler <>

History

#1 Updated by Simon Gilli 3 months ago

  • Due date set to 2019-07-01
  • Start date changed from 2019-07-02 to 2019-07-01
  • Follows Task #88652: Move YamlFileLoader->merge to ArrayUtillity added

#2 Updated by Gerrit Code Review 3 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#3 Updated by Simon Gilli 3 months ago

  • Subject changed from Introduce ArrayUtility::replaceAndAppendScalarValuesRecursive() as public api to Optimize ArrayUtility::replaceAndAppendScalarValuesRecursive()
  • Category set to Code Cleanup

#4 Updated by Simon Gilli 3 months ago

  • Precedes Feature #88676: Introduce new methods of ArrayUtility as public API added

#5 Updated by Simon Gilli 3 months ago

  • Description updated (diff)

#6 Updated by Simon Gilli 3 months ago

  • Tracker changed from Feature to Task
  • Target version changed from Candidate for Major Version to Candidate for patchlevel
  • TYPO3 Version set to 9

#7 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#8 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#9 Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#10 Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#11 Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#12 Updated by Simon Gilli 3 months ago

  • Due date deleted (2019-07-01)
  • Target version changed from Candidate for patchlevel to Candidate for Major Version
  • Start date deleted (2019-07-01)
  • % Done changed from 0 to 100
  • TYPO3 Version changed from 9 to 10
  • Complexity set to medium

#13 Updated by Gerrit Code Review 2 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#14 Updated by Gerrit Code Review 2 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#15 Updated by Gerrit Code Review 2 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#16 Updated by Gerrit Code Review 2 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#17 Updated by Gerrit Code Review 2 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61215

#18 Updated by Simon Gilli 26 days ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF