Task #88746

Move PageRepository to EXT:core

Added by Benni Mack 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Start date:
2019-07-13
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision 0cdab109 (diff)
Added by Benni Mack 6 months ago

[TASK] Move PageRepository to EXT:core

Since Context API was introduced in TYPO3 v9, PageRepository is highly
decoupled from $TSFE->sys_page, and fully works standalone.

It is also used in various places where TSFE is not needed,
or required, but also in places of EXT:core.

Especially parts like RootlineUtility, which depends on PageRepository
very much, cannot live without it.

I propose to move this highly important PHP class into EXT:core,
in order to allow to decouple EXT:frontend even further from
EXT:core.

The FQCN is moved from
- \TYPO3\CMS\Frontend\Page\PageRepository
to
- TYPO3\CMS\Core\Domain\Repository\PageRepository

It can be assumed to use PageRepository for any use-case
and actually reduce usages towards BackendUtility::get...
by using this API more and more.

Further adaptions could be to reduce the logic
within PageRepository and move this into QueryBuilder
and assimilate especially the "versionOL" behavior.

Resolves: #88746
Releases: master
Change-Id: Id8225100ac60bd77fc7e1303efb4c46b741d3415
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61166
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Benjamin Franzke <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Benjamin Franzke <>

History

#1 Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61166

#2 Updated by Gerrit Code Review 6 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61166

#3 Updated by Benni Mack 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF