Task #88859

Remove special TSFE handling in FileCollector

Added by Benni Mack 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
File Abstraction Layer (FAL)
Start date:
2019-07-30
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision 98bf45ab (diff)
Added by Benni Mack 4 months ago

[TASK] Remove special TSFE handling in FileCollector

The FileCollector is e.g. used for resolving
references in the FILES cObject. The check for
TSFE can be removed since the ->getFileReferences
functionality should be used at any time, as the
functionality always handles overlays depending
on the $referenceRecord given.

Resolves: #88859
Releases: master
Change-Id: I500421a12cced80e133b12a0caf6dcf289c6bd9a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61350
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Benni Mack 4 months ago

The FileCollector which is used for resolving
references in FILES cObject etc, the check for TSFE
can be removed, and the ->getFileReferences functionality
should be used at any times, as this always handles
overlays depending on the $referenceRecord given.

#2 Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61350

#3 Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61350

#4 Updated by Benni Mack 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF