Bug #89128

Unrecoverable die() statements allow to not handle an Error

Added by Benni Mack 2 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Logging
Start date:
2019-09-10
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Associated revisions

Revision 2d8a9567 (diff)
Added by Benni Mack 2 months ago

[BUGFIX] Use RuntimeException instead of die()

There are a few places left where Kasper-Kode stopped
a process with die(). Nowadays, with PHP 7, Errors and
Exceptions are used in order to avoid the full stop
of a process.

Using Exceptions instead of die() allows for
ExceptionHandlers to handle such an error and
return a proper HTTP response if called from the web.

Resolves: #89128
Releases: master
Change-Id: Ia50863104fb91303ca3b2ae5ac5cd1466fa982b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61659
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Georg Ringer <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Richard Haeser <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61659

#2 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61659

#3 Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61659

#4 Updated by Benni Mack 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF