Bug #89183

Mixed entrypaths with "/" and FQDN do not work

Added by Benni Mack 29 days ago. Updated 26 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Link Handling, Site Handling & Routing
Start date:
2019-09-17
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When having site configuration with "/" and languages with FQDN this does not resolve.

Associated revisions

Revision eb00d590 (diff)
Added by Benni Mack 26 days ago

[BUGFIX] Handle base paths with mixed FQDN and "/"

If a site has "/" as its entrypoint but the languages
have FQDNs or subdomains or a mixture between subdomain
the base without domain always gets found and the subdomains
are not considered.

Currently this situation is handled in
SiteMatcher->getRouteCollectionForAllSites()
which does not fit a certain scheme if there is a mixture.

This change corrects this and adds tests to handle any cases:

- just / as base, and then /de and /en as language base
- just / as base, and then subdmoains or full domains+path as language base
- a full URL as base, and then path parts as language base
- a full URL as base and then full URLs + subdomains as language base
- Also check for http and http variants.

Resolves: #89183
Releases: master, 9.5
Change-Id: If570118ac371e1a1589f064605c0176a53220f0f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61650
Tested-by: TYPO3com <>
Tested-by: Nicole Cordes <>
Tested-by: Daniel Gorges <>
Tested-by: Benni Mack <>
Reviewed-by: Nicole Cordes <>
Reviewed-by: Daniel Gorges <>
Reviewed-by: Benni Mack <>

Revision 5321891f (diff)
Added by Benni Mack 26 days ago

[BUGFIX] Handle base paths with mixed FQDN and "/"

If a site has "/" as its entrypoint but the languages
have FQDNs or subdomains or a mixture between subdomain
the base without domain always gets found and the subdomains
are not considered.

Currently this situation is handled in
SiteMatcher->getRouteCollectionForAllSites()
which does not fit a certain scheme if there is a mixture.

This change corrects this and adds tests to handle any cases:

- just / as base, and then /de and /en as language base
- just / as base, and then subdmoains or full domains+path as language base
- a full URL as base, and then path parts as language base
- a full URL as base and then full URLs + subdomains as language base
- Also check for http and http variants.

Resolves: #89183
Releases: master, 9.5
Change-Id: If570118ac371e1a1589f064605c0176a53220f0f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61737
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 29 days ago

  • Status changed from New to Under Review

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61650

#2 Updated by Gerrit Code Review 26 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61737

#3 Updated by Benni Mack 26 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review 26 days ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61737

#5 Updated by Benni Mack 26 days ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF