Bug #89419

EXT:backend depends on EXT:install for environment routes, but has no dependency

Added by Daniel Siepmann about 1 month ago. Updated 10 days ago.

Status:
Resolved
Priority:
Should have
Category:
-
Start date:
2019-10-15
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

EXT:install is defining route tools_toolsenvironment while this is used by EXT:backend. Still I can not see a requires to ext install from ext backend.

ag "tools_toolsenv" 
typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/SystemInformationDropDown.html
8:<p class="dropdown-text typo3-module-menu-item submodule mod-tools_toolsenvironment" data-modulename="tools_toolsenvironment">

typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php
173:            'environmentToolUrl' => (string)$uriBuilder->buildUriFromRoute('tools_toolsenvironment'),

typo3/sysext/install/ext_tables.php
51:        'name' => 'tools_toolsenvironment',

Possible solution:

a.fernandez 1:12 PM
I think this requires two steps:
1) generate and render the link only if the route exists (try/catch on RouteNotFoundException or alike)
2) add EXT:install as suggestion

Associated revisions

Revision 9477f2e3 (diff)
Added by Daniel Siepmann 10 days ago

[BUGFIX] Make EXT:backend independent of EXT:install

EXT:backend generates a URL to EXT:install, but has no dependency. This
can lead to composer setups with EXT:backend but without EXT:install,
leading to an exception while generating route.

Therefore a suggest is added as a hint to install also EXT:install.
Existing code is wrapped with an try / catch in order to work under both
circumstances.

Resolves: #89419
Releases: master, 9.5
Change-Id: Idedd299f218ae8f7ba9938800d2ac4a0c4e5614b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61999
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Georg Ringer <>
Tested-by: Susanne Moog <>
Reviewed-by: Karavas Aristeidis <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Susanne Moog <>

Revision 98ccbed1 (diff)
Added by Daniel Siepmann 10 days ago

[BUGFIX] Make EXT:backend independent of EXT:install

EXT:backend generates a URL to EXT:install, but has no dependency. This
can lead to composer setups with EXT:backend but without EXT:install,
leading to an exception while generating route.

Therefore a suggest is added as a hint to install also EXT:install.
Existing code is wrapped with an try / catch in order to work under both
circumstances.

Resolves: #89419
Releases: master, 9.5
Change-Id: Idedd299f218ae8f7ba9938800d2ac4a0c4e5614b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62261
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61999

#2 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61999

#3 Updated by Gerrit Code Review 10 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62261

#4 Updated by Daniel Siepmann 10 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF