Task #89579

Use array as service chains instead of comma-separated list

Added by Benni Mack 17 days ago. Updated about 10 hours ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Authentication
Start date:
2019-11-04
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision da787baa (diff)
Added by Benni Mack about 10 hours ago

[TASK] Use array as service chains instead of comma-separated list

The serviceChain (services that have been requested before)
are currently added as comma-separated list (string), however,
every time when GeneralUtility::makeInstanceService() is called,
the serviceChain parameter is trimExplode'd to an array, which
leads to unnecessary CPU time when multiple services are queried.

The compat behaviour of handing in a string is now deprecated,
and in TYPO3 v11 only arrays are accepted.

Resolves: #89579
Releases: master
Change-Id: Id2424907b0d6c62fc1f249bcdd23f13d45de9893
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62043
Reviewed-by: Daniel Goerz <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Oliver Hader <>
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review 17 days ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62043

#2 Updated by Gerrit Code Review 16 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62043

#3 Updated by Benni Mack about 10 hours ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF