Bug #90231

Linkvalidator makes use of rowCount() and does not work with sqlite

Added by Daniel Siepmann 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2020-01-28
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In some places rowCount() is used. Accordingly to Bug #78129 this doesn't work on all DBMS, e.g. sqlite does not work.

The result is an empty report, even if records exist in the database.


Related issues

Related to TYPO3 Core - Bug #78129: Statement::rowCount not reliable for SELECT queries Closed 2016-10-02

Associated revisions

Revision f02f4e22 (diff)
Added by Daniel Siepmann 9 months ago

[BUGFIX] Do not use rowCount() in linkvalidator report

As `rowCount()` is not supported across all DBMS (e.g. sqlite).

The logic is kept, but instead of relying on row count, the list of
items is built first, and checked afterwards.

Resolves: #90231
Releases: master
Change-Id: Iad0dc46c507d300708c9bc9d53aad6d6840a3446
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63061
Tested-by: TYPO3com <>
Tested-by: Sybille Peters <>
Tested-by: Benni Mack <>
Reviewed-by: Sybille Peters <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Daniel Siepmann 9 months ago

  • Related to Bug #78129: Statement::rowCount not reliable for SELECT queries added

#2 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63061

#3 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63061

#4 Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63061

#5 Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63061

#6 Updated by Daniel Siepmann 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF