Project

General

Profile

Actions

Task #90255

closed

Break down func_delete in ExtendedFileUtility into smaller methods for better overriding

Added by Leo Viezens about 4 years ago. Updated about 4 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2020-01-30
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The public method 'func_delete' in TYPO3\CMS\Core\Utility\File\ExtendedFileUtility is currently ~150 lines long. I'd like to break this down into smaller (protected) sub methods.

Advantages:
You can use the XClass mechanism more effectively, as it would be possible to override only one sub method instead of having to override the whole 'func_delete' method.

Background:
I'm currently using a composer patch to hook into the 'func_delete' method. This has to get maintained, as the 'ExtendedFileUtility' changes from time to time and the composer patch has to get adjusted.

Actions #1

Updated by Leo Viezens about 4 years ago

  • Subject changed from Break down func_delete in ExtendedFileUtility for better overriding to Break down func_delete in ExtendedFileUtility into smaller methods for better overriding
Actions #2

Updated by Georg Ringer about 4 years ago

  • Status changed from New to Rejected

Thanks for creating the isssue. With #90020 this class has moved to internal +

this class should not be used anymore outside of TYPO3 Core, and is considered internal,
as the FAL API should be used instead.

see also https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/7.4/Deprecation-63603-ExtendedFileUtilitydontCheckForUniqueIsDeprecated.html

therefore I am closing this issue.

Actions

Also available in: Atom PDF