Bug #90761

Fluid select viewhelper not added to __trustedProperties if multiple="true" but it has no options

Added by Marco Huber 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-03-14
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The registerFieldNameForFormTokenGeneration is not called, if the viewhelper has multiple="true" but has no options. Then the field is not added to the hidden "__trustedProperties" field. But when the form is submitted, the select field is in the sent array with an empty string as value and then the extbase data mapper throws the exception 1297759968.

See: https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php#L153

Associated revisions

Revision e3d0640e (diff)
Added by Marco Huber 2 months ago

[BUGFIX] Avoid validation failure on multi select fields without option

Multi Select fields without any option given will be added properly to
the forms __trustedProperties list and therefor no longer cause
validation errors.

Resolves: #90761
Releases: master, 9.5
Change-Id: I3c73ffbbd38a9a2ae24ed4b271efc1c4ce248d53
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63720
Tested-by: TYPO3com <>
Tested-by: Marco Huber <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Marco Huber <>
Reviewed-by: Anja Leichsenring <>

Revision 7cc2a367 (diff)
Added by Marco Huber 2 months ago

[BUGFIX] Avoid validation failure on multi select fields without option

Multi Select fields without any option given will be added properly to
the forms __trustedProperties list and therefor no longer cause
validation errors.

Resolves: #90761
Releases: master, 9.5
Change-Id: I3c73ffbbd38a9a2ae24ed4b271efc1c4ce248d53
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63791
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63720

#2 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63720

#3 Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63720

#4 Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63720

#5 Updated by Gerrit Code Review 2 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63720

#6 Updated by Gerrit Code Review 2 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63720

#7 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63791

#8 Updated by Marco Huber 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF