Bug #91022

DataHandler->remapListedDBRecords_procInline should avoid array_map

Added by Benni Mack 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Category:
DataHandler aka TCEmain
Target version:
Start date:
2020-04-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

From the review on

https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699/44/typo3/sysext/core/Classes/DataHandling/DataHandler.php#5548

Should we trim and int cast in method `getAutoVersionId()`? AFAICS, the value is retrieved from there and could be handled there correctly also for all other usages. With that, the array_map would not be needed here and also the int cast for the update `$conn->update($tableName, $updateValues, ['uid' => (int)$uid])`.

#1

Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64160

#2

Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64160

#3

Updated by Manuel Selbach 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF