Bug #91369
closed
AbstractProvider->identifier string?
0%
Description
I've been doing some PHPStan work with the TYPO3 Crawler, and found that I use
$crawlerConfiguration = BackendUtility::getRecordWSOL($this->table, $this->identifier); (1) Where the $this->identifier is a string as it's inherited from TYPO3\CMS\Backend\ContextMenu\ItemProviders\AbstractProvider (2) but should have been int according to BackendUtility::getRecordWSOL().
I'm not sure if I'm doing a faulty implementation or if the AbstractProvider Identifier should be different.
Hope you can help shed some light on this.
1) https://github.com/AOEpeople/crawler/blob/master/Classes/ContextMenu/ItemProvider.php#L70
2) https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/backend/Classes/ContextMenu/ItemProviders/AbstractProvider.php#L74
Updated by Christian Kuhn almost 3 years ago
- Status changed from New to Closed
Thanks. We did lots of fixes like that meanwhile.
The getRecordWSOL() call now has an (int) cast for the identifier.
Closing issue.
Updated by Christian Kuhn almost 3 years ago
- Related to Task #92111: Fix phpstan checkFunctionArgumentTypes errors in ext:backend added