Project

General

Profile

Actions
Copy link

Bug #91784

closed

Extbase ObjectAcces::isPropertyGettable ArrayAccess logic breaks usability

Added by Till Wimmer almost 4 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2020-07-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
extbase reflection
Complexity:
Is Regression:
Sprint Focus:

Description

Hi there,

Since commit 2a4dcbad895 the logic to check if a property is gettable is somehow reversed...

This implies that a model class implementing ArrayAccess solely has properties which are accessible as array offsets:

    if (($object instanceof \ArrayAccess) && !$object->offsetExists($propertyName)) {
        return false;
    }

This makes it impossible to use the ArrayAccess Interface only for a few properties like in earlier versions. This was handy i.e. to implement some "magic" getters in Fluid.

Actions
Copy link
 #1

Updated by Till Wimmer over 3 years ago

Anybody home?

Actions
Copy link
 #2

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65234

Actions
Copy link
 #3

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65234

Actions
Copy link
 #4

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65234

Actions
Copy link
 #5

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65234

Actions
Copy link
 #6

Updated by Anonymous over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65756

Actions
Copy link
 #8

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65756

Actions
Copy link
 #9

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65756

Actions
Copy link
 #10

Updated by Riccardo De Contardi 10 months ago

  • Status changed from Under Review to Closed

Abandoned for 10.4 -> closing it

If you think that this is the wrong decision or experience the issue again, please reopen it or open a new issue with a reference to this one. Thank you.

Actions
Copy link

Also available in: Atom PDF