Bug #92032
closed
ImageService::setCompatibilityValues breaks when file missing
100%
Description
The \TYPO3\CMS\Extbase\ServiceImageService breaks hard when calling setCompatibilityValues with missing images.
This is because $processedImage->getPublicUrl() can return NULL instead of a string, but the AssetCollector requires a string input.
This causes a TypeError and will break if an image object is provided with missing=1.
We should probably check for that NULL return value of getPublicUrl here, to prevent hard breaks.
Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65353
Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65353
Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65353
Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65373
Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65373
Updated by Anonymous over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7d0961e2d8d580c710446435eaebc1169123b203.
Updated by Gerrit Code Review over 3 years ago
- Status changed from Resolved to Under Review
Patch set 3 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65373
Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65373
Updated by Anonymous over 3 years ago
- Status changed from Under Review to Resolved
Applied in changeset 0bed3d3a4a3fce2a42688eff16b7aec6243ae8b3.
Updated by