Project

General

Profile

Actions

Bug #92181

closed

TYPO3\CMS\Core\Configuration\ExtensionConfiguration->set paremter; anotation for third parameter wrong

Added by Timo Poppinga about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2020-09-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.4
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

Is

    /**
     * @param string $extension Extension name
     * @param string $path Configuration path to set - eg. "featureCategory/coolThingIsEnabled" 
     * @param null $value The value. If null, unset the path
     * @internal
     */
    public function set(string $extension, string $path = '', $value = null): void
    {

should be

    /**
     * @param string $extension Extension name
     * @param string $path Configuration path to set - eg. "featureCategory/coolThingIsEnabled" 
     * @param string|null $value The value. If null, unset the path
     * @internal
     */
    public function set(string $extension, string $path = '', ?string $value = null): void
    {

Triggers PHP Stan violation:

Parameter #3 $value of method TYPO3\CMS\Core\Configuration\ExtensionConfiguration::set() expects null, string given.

Actions #1

Updated by Timo Poppinga about 4 years ago

  • Subject changed from TYPO3\CMS\Core\Configuration->set paremter; anoteded for third parameter wrong to TYPO3\CMS\Core\Configuration->set paremter; anotation for third parameter wrong
Actions #2

Updated by Timo Poppinga about 4 years ago

  • Subject changed from TYPO3\CMS\Core\Configuration->set paremter; anotation for third parameter wrong to TYPO3\CMS\Core\Configuration\ExtensionConfiguration->set paremter; anotation for third parameter wrong
Actions #3

Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65541

Actions #4

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65541

Actions #5

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65541

Actions #6

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65567

Actions #7

Updated by Timo Poppinga about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF